Skip to content

chore(entry_point): remove all repository_rule entry_point code and docs#3735

Open
aignas wants to merge 1 commit intobazel-contrib:mainfrom
aignas:aignas.chore.remove-entry-points-2
Open

chore(entry_point): remove all repository_rule entry_point code and docs#3735
aignas wants to merge 1 commit intobazel-contrib:mainfrom
aignas:aignas.chore.remove-entry-points-2

Conversation

@aignas
Copy link
Copy Markdown
Collaborator

@aignas aignas commented Apr 24, 2026 •
edited
Loading

This PR remove any mention or supporting code for the legacy
(and long removed) entry_point macro.

Fixes #3642

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the legacy entry point generation mechanism and the deprecated entry_point macro in favor of py_console_script_binary. The changes include removing the parsing of entry_points.txt from wheel metadata, deleting the logic that automatically generated py_binary targets and entry point scripts within whl_library, and cleaning up associated tests and documentation. I have no feedback to provide as there are no review comments to address.

@aignas aignas force-pushed the aignas.chore.remove-entry-points-2 branch from d18adbb to 39e8cc3 Compare April 26, 2026 13:53
@aignas aignas marked this pull request as ready for review April 26, 2026 13:54
@aignas aignas requested a review from groodt as a code owner April 26, 2026 13:54
@aignas aignas enabled auto-merge April 26, 2026 13:54
@aignas aignas force-pushed the aignas.chore.remove-entry-points-2 branch from 39e8cc3 to 65e3c97 Compare April 26, 2026 13:55
@rickeylev
Copy link
Copy Markdown
Collaborator

rickeylev commented Apr 26, 2026

looks like legit ci error:

(18:57:51) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/rules_python_publish_deps_twine/BUILD.bazel: no such target '@@rules_python_publish_deps_twine//:rules_python_wheel_entry_point_twine.py': target 'rules_python_wheel_entry_point_twine.py' not declared in package '' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/rules_python_publish_deps_twine/BUILD.bazel
(18:57:51) ERROR: /workdir/examples/wheel/BUILD.bazel:58:9: no such target '@@rules_python_publish_deps_twine//:rules_python_wheel_entry_point_twine.py': target 'rules_python_wheel_entry_point_twine.py' not declared in package '' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/rules_python_publish_deps_twine/BUILD.bazel and referenced by '//examples/wheel:minimal_with_py_library.publish'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickeylev rickeylev rickeylev approved these changes

@groodt groodt Awaiting requested review from groodt groodt is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs] pip.parse still mentions the defunct entry_point

2 participants

@aignas @rickeylev